[6.0] Move CMS Filesystem package to compat plugin by Hackwar · Pull Request #44240 · joomla/joomla-cms

Hackwar · 2024-10-12T12:58:19Z

Summary of Changes

This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.

I've added the Composer Dependency Changed label because the PR requires composer i to be run.

Testing Instructions

Copy the following line in a view of your choice to generate a call to the legacy classes:

var_dump(\Joomla\CMS\Filesystem\Folder::listFolderTree(JPATH_BASE, '.'));

Make sure the compat plugin is enabled AND you have to run composer i to generate an updated class loader file
Visit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Adding move of CMS filesystem package to compat plugin Manual#376
No documentation changes for manual.joomla.org needed

laoneo · 2024-10-14T06:48:40Z

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so.

Hackwar · 2024-10-14T08:21:53Z

Done

plugins/behaviour/compat/compat.xml

Co-authored-by: jsanders <j53.sanders@gmail.com>

Bodge-IT · 2025-02-12T08:42:13Z

Thanks for all the work on these @Hackwar, can you resolve this little conflict? Then we can merge.

plugins/behaviour/compat/compat.xml

Bodge-IT · 2025-03-03T21:05:39Z

I have tested this item ✅ successfully on f7007b8

Good test after full wipe.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.}

softforge · 2025-03-03T21:07:33Z

Tested that the folder did not exist and then it all worked. Better testing instructions please

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.}

softforge · 2025-03-03T21:08:42Z

I have tested this item ✅ successfully on f7007b8

When I worked out what was actually needed... it worked

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.}

* Add deleted files and folders 2025-02-28 - New 5.x update SQL scripts - Deleted files and folder from PR #43907 minus the file added back with PR #45015 * Add deleted files from PR #45021 * Add deleted files and folders from PRs #44240 and #45020 * Add new 5.3 update SQL scripts to deleted files --------- Co-authored-by: Gary Barclay <1881642+Bodge-IT@users.noreply.github.com>

considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884

* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Restore class aliases from compat 5 plugin * Relocate files from #44925 --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Brian Teeman <brian@teeman.net>

* Create backward compatibility 6 plugin * Moved relevant code from old compat plugin and removed it considered changes from prs: #44926 #44240 #44638 #44700 #43209 #43958 #42884 * Add new plugin on install and uninstall old plugin * Remove compat media folder, add compat6 removed.asset.json * Fix cs exceptions * Update ExtensionHelper * Rename Compat.php to Compat6.php * Disable compat6 plugin for system tests * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/plg_behaviour_compat6.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/language/en-GB/plg_behaviour_compat6.sys.ini Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/src/Extension/Compat6.php * Restore class aliases from compat 5 plugin * Relocate files from #44925 * Apply language string improvement from review suggestion Co-authored-by: Brian Teeman <brian@teeman.net> * Update plugins/behaviour/compat6/src/Extension/Compat6.php Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update plugins/behaviour/compat6/compat6.xml Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update installation/sql/mysql/base.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Update installation/sql/postgresql/base.sql Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Fix wrong folder in uninstallation of compat (5) plugin. --------- Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: Richard Fath <richard.fath@t-online.de> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

Move CMS Filesystem package to compat plugin

8e575af

Hackwar added Feature Composer Dependency Changed labels Oct 12, 2024

joomla-cms-bot added PR-6.0-dev and removed Composer Dependency Changed labels Oct 12, 2024

Hackwar added the Composer Dependency Changed label Oct 12, 2024

Hackwar mentioned this pull request Oct 12, 2024

[6.0] Deleting CMS Filesystem Package #43972

Closed

7 tasks

Fixing codestyle checker

6c149f0

joomla-cms-bot removed the Composer Dependency Changed label Oct 12, 2024

joomla-cms-bot added the Language Change This is for Translators label Oct 14, 2024

Add option and move files around

770e5d1

Hackwar force-pushed the 6.0-filesystem2 branch from e776cd0 to 770e5d1 Compare October 14, 2024 08:20

Hackwar added 2 commits October 14, 2024 10:33

Fixing codestyle rules

95fcc1e

Fixing path

9d7f7dd

sandewt reviewed Oct 14, 2024

View reviewed changes

plugins/behaviour/compat/compat.xml Outdated Show resolved Hide resolved

Hackwar and others added 4 commits November 21, 2024 20:42

Update plugins/behaviour/compat/compat.xml

80eb0ba

Co-authored-by: jsanders <j53.sanders@gmail.com>

Update ruleset.xml

708086a

Update Compat.php

350bd4a

Update compat.xml

2fd0c76

Hackwar mentioned this pull request Jan 31, 2025

Adding move of CMS filesystem package to compat plugin joomla/Manual#376

Merged

Hackwar added 2 commits February 14, 2025 15:53

Merge branch '6.0-dev' into 6.0-filesystem2

046172b

codestyle

73894fe

laoneo mentioned this pull request Feb 17, 2025

[6.0] Add removed Input classes to the compat plugin #44925

Merged

4 tasks

laoneo reviewed Feb 17, 2025

View reviewed changes

plugins/behaviour/compat/compat.xml Show resolved Hide resolved

laoneo mentioned this pull request Feb 17, 2025

[6.0] Add removed Application classes to the compat plugin #44926

Merged

4 tasks

Bodge-IT and others added 2 commits February 19, 2025 08:40

Merge branch '6.0-dev' into 6.0-filesystem2

9db0364

Merge branch '6.0-dev' into 6.0-filesystem2

4da6161

Merge branch '6.0-dev' into 6.0-filesystem2

f7007b8

Bodge-IT added the RTC This Pull Request is Ready To Commit label Mar 3, 2025

Bodge-IT merged commit 45c1e37 into joomla:6.0-dev Mar 3, 2025
4 of 5 checks passed

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 3, 2025

QuyTon added this to the Joomla! 6.0.0 milestone Mar 3, 2025

jgerman-bot mentioned this pull request Mar 4, 2025

[6.0] Move CMS Filesystem package to compat plugin joomlagerman/joomla#3411

Closed

richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2025

Add deleted files and folders from PRs joomla#44240 and joomla#45020

a0efefd

richard67 mentioned this pull request Mar 4, 2025

[6.0] Update deleted files and folders in script.php 2025-02-28 #45038

Merged

4 tasks

Hackwar deleted the 6.0-filesystem2 branch March 4, 2025 10:31

This was referenced Mar 4, 2025

[6.1] Drop Bootstrap::framework #44991

Closed

[6.1] Media: fix large file upload by using of binary upload instead of base64, and display correct upload progress #44848

Open

HLeithner added a commit to HLeithner/joomla-cms that referenced this pull request Apr 16, 2025

Moved relevant code from old compat plugin and removed it

7cd89fa

considered changes from prs: joomla#44926 joomla#44240 joomla#44638 joomla#44700 joomla#43209 joomla#43958 joomla#42884

richard67 mentioned this pull request Apr 29, 2025

[6.0] Disable compat plugin for system tests again #45414

Merged

4 tasks

Rahulsingh1939 mentioned this pull request Aug 1, 2025

Import fails on Joomla 6 alpha3 joomla-projects/JA-Advanced-Migration-Tool#23

Closed

qodo-code-review bot mentioned this pull request Aug 23, 2025

Update new features documentation for version changes joomla/Manual#507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[6.0] Move CMS Filesystem package to compat plugin#44240

[6.0] Move CMS Filesystem package to compat plugin#44240
Bodge-IT merged 14 commits intojoomla:6.0-devfrom
Hackwar:6.0-filesystem2

Hackwar commented Oct 12, 2024 •

edited

Loading

Uh oh!

laoneo commented Oct 14, 2024

Uh oh!

Hackwar commented Oct 14, 2024

Uh oh!

Uh oh!

Bodge-IT commented Feb 12, 2025

Uh oh!

Uh oh!

Bodge-IT commented Mar 3, 2025

Uh oh!

softforge commented Mar 3, 2025

Uh oh!

softforge commented Mar 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Hackwar commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Link to documentations

Uh oh!

laoneo commented Oct 14, 2024

Uh oh!

Hackwar commented Oct 14, 2024

Uh oh!

Uh oh!

Bodge-IT commented Feb 12, 2025

Uh oh!

Uh oh!

Bodge-IT commented Mar 3, 2025

Uh oh!

softforge commented Mar 3, 2025

Uh oh!

softforge commented Mar 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Hackwar commented Oct 12, 2024 •

edited

Loading